Repository navigation
Fix comment parsed as a shellcheck directive in test-provision-tools.sh - #2346
Closed
remigiusz-antczak wants to merge 1 commit into
Closed
remigiusz-antczak wants to merge 1 commit into
remigiusz-antczak wants to merge 1 commit into
Conversation
A comment starting with '# shellcheck, ruff and ...' is parsed by shellcheck as a directive (SC1073/SC1072), so shellcheck stopped checking the file. Reword to '# The shellcheck, ruff and ...'. No other tracked *.sh file has a non-directive '# shellcheck' comment. shellcheck -S warning now reports no findings on the file. Tests: 61/61 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded: main already carries this fix (merged in #2339). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment on line 177 began with
# shellcheck,, which shellcheck parses as a directive. It failed with SC1073/SC1072 and stopped checking the rest of the file. The comment is reworded. No other tracked script has this pattern.Tests: 61/61 (test-provision-tools.sh).
shellcheck -S warningon the file now exits 0.🤖 Generated with Claude Code